Conversation
…into feature-coverage
| # rayleigh | ||
| # ---------------------------------------------------------------------- | ||
|
|
||
| <<<<<<< HEAD |
There was a problem hiding this comment.
well that's weird
planes
left a comment
planes
left a comment
There was a problem hiding this comment.
Make some changes. Talk to Matthew about one issue
| @@ -1,167 +0,0 @@ | |||
| cruise | |||
There was a problem hiding this comment.
Idk...why, but the regression/travis works.... @mclarke2 might be able to comment on the use of it.
| actual.takeoff = 99.7 | ||
| actual.side_line = 97.2 | ||
| actual.landing = 105.2 | ||
| actual.takeoff = 99.982372547196633 |
There was a problem hiding this comment.
Hmm, I think these values actually come from Shevell data as a test case. I think what you have done is right. However, we should save the original values in comments somewhere.
| @@ -0,0 +1,102 @@ | |||
| # constnat_temperature.py | |||
| @@ -0,0 +1,73 @@ | |||
| # NACA_airfoil_compute.py | |||
| Cm_a_sur[ii,jj] = cm_alpha_surrogate.predict(np.array([AoA_mesh[ii,jj],mach_mesh[ii,jj]])) | ||
| Cn_b_sur[ii,jj] = cn_beta_surrogate.predict(np.array([AoA_mesh[ii,jj],mach_mesh[ii,jj]])) | ||
| NP_sur[ii,jj] = neutral_point_surrogate.predict(np.array([AoA_mesh[ii,jj],mach_mesh[ii,jj]])) | ||
| NP_sur[ii,jj] = neutral_point_surrogate.predict(np.array([AoA_mesh[ii,jj],mach_mesh[ii,jj]])) |
There was a problem hiding this comment.
There wasn't a change...The commented code below allows the sklearn to work on my own machine. I assume my version is more up to date than the SUAVE repo.
There was a problem hiding this comment.
Keep those differences locally...have @mclarke2 comment on it
| g = self.compute_gamma(T,p) | ||
| else: | ||
| g = 1.4*np.ones_like(T) | ||
|
|
There was a problem hiding this comment.
nope, I changed It...
|
|
||
| T = np.resize(T,[n_a,3,3]) | ||
|
|
||
| return T |
There was a problem hiding this comment.
You should make this a regression
There was a problem hiding this comment.
So this is already being covered...are you sure you want another regression?
3 participants
Just a general code clean up.
Added regression for Ducted Fan and NACA airfoil geometry for coverage.