Conversation
timdmacdo
left a comment
timdmacdo
left a comment
There was a problem hiding this comment.
See comments. Changes should all be relatively minor.
| SECTION | ||
| #Xle Yle Zle Chord Ainc Nspanwise Sspace | ||
| 32.4164746575 1.54 7.777 0.95 0.0 | ||
| 32.4164746575 0.0 7.777 0.95 0.0 |
There was a problem hiding this comment.
This file seems unrelated.
There was a problem hiding this comment.
So according to matt...this files is worthless, it is generated everytime the regression is run
There was a problem hiding this comment.
My impression was that it was supposed to be checked to make sure it was consistent. That doesn't seem to be true here.
There was a problem hiding this comment.
Make this an issue for AVL coverage
| @@ -0,0 +1,244 @@ | |||
| # sramjet_network.py | |||
| conditions = SUAVE.Analyses.Mission.Segments.Conditions.Aerodynamics() | ||
|
|
||
| # freestream conditions | ||
| EVAL = conditions.freestream |
There was a problem hiding this comment.
variables should be lower case
| conditions_sizing = SUAVE.Analyses.Mission.Segments.Conditions.Aerodynamics() | ||
|
|
||
| # freestream conditions | ||
| SIZE = conditions_sizing.freestream |
There was a problem hiding this comment.
variables should be lower case
| scramjet.thrust = thrust | ||
|
|
||
| #size the ramjet | ||
| scramjet_sizing(scramjet,6.5,20000.0) |
There was a problem hiding this comment.
Identify hard coded values
| mdot_core = mdhc*np.sqrt(Tref/total_temperature_reference)*(total_pressure_reference/Pref) | ||
|
|
||
| # computing the dimensional thrust | ||
| #computing the dimensional thrust |
There was a problem hiding this comment.
Personally I like the space. I think this will be an ongoing battle.
There was a problem hiding this comment.
So do I, i dont know why I changed it
There was a problem hiding this comment.
oh...cause thats how the rest of the script was written.
| fuel_flow_rate = np.fmax(0.1019715*FD2*TSFC/3600.,a) #use units package for the constants | ||
| # computing the power | ||
| fuel_flow_rate = np.fmax(0.1019715*FD2*TSFC/3600,a) #use units package for the constants |
There was a problem hiding this comment.
These numbers should be replaced so that the source is clear. In general though you should leave the decimal. This is good practice to avoid issues with integers.
There was a problem hiding this comment.
So add 1/g and unit conversion for the 3600?
There was a problem hiding this comment.
I left it how it is for now, as I did not alter/use this portion of code. I used evaluate stream thrust.
| Assumptions: | ||
|
|
||
| Source: | ||
| Heiser, William H., Pratt, D. T., Daley, D. H., and Unmeel, B. M., |
There was a problem hiding this comment.
Provide relevant chapters/pages
| """ | ||
|
|
||
| # Calculate wave angle | ||
| MU = np.arcsin(1./M0) |
There was a problem hiding this comment.
variables should be lower case if there is no compelling reason otherwise (i.e. CL v cl)
| conditions.freestream.density = np.atleast_1d(rho) | ||
| conditions.freestream.dynamic_viscosity = np.atleast_1d(mu) | ||
| conditions.freestream.gravity = np.atleast_1d(9.81) | ||
| conditions.freestream.isentropic_expansion_factor = np.atleast_1d(scramjet.working_fluid.compute_gamma(T,p)) |
There was a problem hiding this comment.
I know this is a common oversight in other parts of the code, but please provide a not hard coded value for gravity.
3 participants
Pull Request Checklist