Drop upvote events from PUSH_EVENT_TYPES palette (@sublay/node)#21
Merged
Conversation
entity-upvote and comment-upvote are no longer push events (they remain in-app-only AppNotification types). Mirror the server's PUSH_EVENT_TYPES, which dropped them, so @sublay/node's exported palette stays in sync. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mirrors the server change making
entity-upvote/comment-upvotein-app-only. They're no longer push events, so@sublay/node's exportedPUSH_EVENT_TYPES/PushEventTypemust drop them to stay in sync with the server.PUSH_EVENT_TYPESinsrc/interfaces/Push.ts.AppNotificationtype union untouched — upvotes remain valid in-app notification types.Part of a coordinated set: server (merged), dashboard (merged), docs,
@sublay/core,@sublay/js.🤖 Generated with Claude Code