Skip to content

Fixing Results Output#37

Merged
hugh-sublime merged 2 commits intosublime-security:masterfrom
harrison-bornstein:output_fixes
Jun 18, 2024
Merged

Fixing Results Output#37
hugh-sublime merged 2 commits intosublime-security:masterfrom
harrison-bornstein:output_fixes

Conversation

@harrison-bornstein
Copy link
Copy Markdown
Contributor

@harrison-bornstein harrison-bornstein commented Jun 13, 2024

The results output from Sublime Analyze is currently broken. My guess is that the API changed. I made the fixes below to display the output correctly.

  • Updated Templates to Correctly Display Output of Rule and Insight values and names
  • Fixes issues where the results field doesn't exist and where the arrays have null values or are empty

Current:

image

After:
image

@harrison-bornstein harrison-bornstein marked this pull request as ready for review June 13, 2024 15:38
@harrison-bornstein
Copy link
Copy Markdown
Contributor Author

@hugh-sublime

Copy link
Copy Markdown
Member

@hugh-sublime hugh-sublime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! We'll publish a release soon!

@hugh-sublime hugh-sublime merged commit 8558071 into sublime-security:master Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants