Skip to content

Support hybrid mode in cooperation with LSP-typescript #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Sep 30, 2025
Merged

Support hybrid mode in cooperation with LSP-typescript #154

merged 15 commits into from
Sep 30, 2025

Conversation

@rchl
Copy link
Member

@rchl rchl commented Sep 2, 2025 •
edited
Loading

TODO:

  • Look whether some capabilities should be disabled or prioritized
  • Choose the most appropriate scopes for component, markdown and html semantic tokens

dependabot bot and others added 2 commits August 20, 2025 17:17
@dependabot
Bump @vue/language-server from 2.2.8 to 3.0.6 in /server
3fb0c1c 
Bumps [@vue/language-server](https://github.com/vuejs/language-tools/tree/HEAD/packages/language-server) from 2.2.8 to 3.0.6.
- [Release notes](https://github.com/vuejs/language-tools/releases)
- [Changelog](https://github.com/vuejs/language-tools/blob/master/CHANGELOG.md)
- [Commits](https://github.com/vuejs/language-tools/commits/v3.0.6/packages/language-server)

---
updated-dependencies:
- dependency-name: "@vue/language-server"
  dependency-version: 3.0.6
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@rchl
Support hybrid mode in cooperation with LSP-typescript
d363a22
@rchl rchl mentioned this pull request Sep 2, 2025
Merged
@predragnikolic predragnikolic mentioned this pull request Sep 23, 2025
Closed
@rchl rchl marked this pull request as ready for review September 23, 2025 20:49
@rchl rchl mentioned this pull request Sep 23, 2025
Merged
predragnikolic
predragnikolic approved these changes Sep 27, 2025
View reviewed changes
Copy link
Member

@predragnikolic predragnikolic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in combination with sublimelsp/LSP-typescript#274, and it works!

The changes in LSP-typescript were pretty easy to understand
and the solution with the typescript-plugins.json contribution file is nice 👍

Thank you again Rafal for the PR's!

I didn't test the tsserver/request notification,
not sure how/when the server will send the tsserver/request notification.

If you can say how to test that, I can try that as well.

@rchl
Copy link
Member Author

rchl commented Sep 28, 2025

The tsserver/request should happen quite frequently. For example when moving cursor around or completing some JS/TS.

@rchl
Copy link
Member Author

rchl commented Sep 28, 2025

We should figure out a good scope for the semantic tokens. Currently I think those stand out too much in Mariana at least.

Screenshot 2025-09-28 at 11 30 22

@rchl
Copy link
Member Author

rchl commented Sep 30, 2025 •
edited
Loading

I've changed scopes for semantic tokens to entity.name.tag.vue which means that there won't be any special coloring for those with a typical color scheme but one can customize color scheme if needed.

vscode extension also uses same scopes for all 3 tags so I followed it without thinking too much about it.

@rchl rchl merged commit 45558cb into master Sep 30, 2025
@rchl rchl deleted the fix/hybrid branch September 30, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@predragnikolic predragnikolic predragnikolic approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rchl @predragnikolic