Fix missing punctuation scope in log syntax#2805
Merged
jwortmann merged 1 commit intosublimelsp:mainfrom Mar 12, 2026
Merged
Conversation
This commit scopes brackets according to ST's scope naming guidelines, to ensure proper colors are assigned without syntax specific color scheme rules being required.
✅ Deploy Preview for sublime-lsp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
jwortmann
approved these changes
Mar 12, 2026
Member
jwortmann
left a comment
jwortmann
left a comment
There was a problem hiding this comment.
We should probably revise this syntax some day.
For example the base scope starting with output. is quite uncommon, and variable.function and keyword.control for the server name and for the request/notification type also seem to be chosen just based on the colors from a specific color scheme and not based on semantic meaning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit scopes brackets according to ST's scope naming guidelines, to ensure proper colors are assigned without syntax specific color scheme rules being required.