Skip to content

Make Goto Diagnostics panel follow show_diagnostics_severity_level#2856

Merged
jwortmann merged 4 commits intosublimelsp:mainfrom
jwortmann:goto-diagnostic-setting
Apr 9, 2026
Merged

Make Goto Diagnostics panel follow show_diagnostics_severity_level#2856
jwortmann merged 4 commits intosublimelsp:mainfrom
jwortmann:goto-diagnostic-setting

Conversation

@jwortmann
Copy link
Copy Markdown
Member

Resolves #2844

Changes value for severity of inlcuded diagnostics in "Goto Diagnostic" panel from diagnostics_panel_include_severity_level to show_diagnostics_severity_level setting, so that included diagnostics match those which are visible in the view.

Also adds optional "severity_level" command argument to make it possible to override that value.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 8, 2026

Deploy Preview for sublime-lsp ready!

Name Link
🔨 Latest commit 25f4585
🔍 Latest deploy log https://app.netlify.com/projects/sublime-lsp/deploys/69d6822b99bf2b0007d48623
😎 Deploy Preview https://deploy-preview-2856--sublime-lsp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@rchl
Copy link
Copy Markdown
Member

rchl commented Apr 8, 2026

I guess commit summary could be improved so that it's more clear from the change log perspective what has changed.

By default show_diagnostics_severity_level and diagnostics_panel_include_severity_level are set to 4 so there are no changes for default settings.

Maybe: "Make Goto Diagnostics panel follow show_diagnostics_severity_level"

(since this PR makes two semi related chagnes it would be hard to fit both)

Comment thread plugin/goto.py Outdated
@jwortmann jwortmann changed the title Adjust severity level of included diagnostics in Goto Diagnostic panel Make Goto Diagnostics panel follow show_diagnostics_severity_level Apr 9, 2026
@jwortmann jwortmann merged commit be2fcf5 into sublimelsp:main Apr 9, 2026
8 checks passed
@jwortmann jwortmann deleted the goto-diagnostic-setting branch April 9, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configurable Goto Diagnostic command threshold

2 participants