Deep copy all ClientConfig properties when copying it#2861
Merged
Conversation
rchl
changed the title
jwortmann
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that all properties are deep-copied when "copying"
ClientConfig. This ensures that starting new plugin instances always starts with a clean base settings that don't include any modifications that might have been added by the plugin instance.We have previously had issues like sublimelsp/lsp_utils#120 or https://github.com/sublimelsp/LSP-clangd/blob/feb5696aad122ac6c7de3f3d45feda50824026ea/plugin.py#L189-L191 that were worked around in lsp_utils or LSP-clangd but the proper fix is to ensure that this never happens.