fix(bonjour): also suppress CIAO PROBING CANCELLED in rejection handler#5
Open
suboss87 wants to merge 50 commits into
Open
fix(bonjour): also suppress CIAO PROBING CANCELLED in rejection handler#5suboss87 wants to merge 50 commits into
suboss87 wants to merge 50 commits into
Conversation
ignoreCiaoCancellationRejection only matched "CIAO ANNOUNCEMENT CANCELLED". The ciao library also emits "CIAO PROBING CANCELLED" during mDNS probing on startup, which was not matched and fell through to the global unhandled rejection handler, causing the gateway process to exit. Extend the check to cover both ANNOUNCEMENT and PROBING variants. Add a dedicated test file for the function. Closes openclaw#71869
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ignoreCiaoCancellationRejectiononly matched\"CIAO ANNOUNCEMENT CANCELLED\". The ciao library also emits\"CIAO PROBING CANCELLED\"during mDNS probing on startup. That string was not matched, so it fell through to the global unhandled rejection handler and killed the gateway process.This extends the check to cover both variants.
Root Cause
src/infra/bonjour-ciao.tsline 6 had a singleincludes(\"CIAO ANNOUNCEMENT CANCELLED\")check. The ciao library has two cancellation paths:CIAO ANNOUNCEMENT CANCELLEDCIAO PROBING CANCELLEDOnly the first was handled. On affected machines the gateway exits on startup with:
Fix
Added
CIAO PROBING CANCELLEDto the rejection check inignoreCiaoCancellationRejection. One-line logic change.Test Plan
src/infra/bonjour-ciao.test.tswith 9 tests covering: ANNOUNCEMENT suppressed, PROBING suppressed, case-insensitive matching, unrelated errors not suppressed, debug log fired on suppress, debug log not fired on pass-throughsrc/infra/bonjour.test.tstests pass unchangedCloses openclaw#71869
Generated by Claude Code