feat(isthmus): observe scalar function types - #1015
Conversation
|
Did a quick pass and the direciton seems reasonable overall. Planning on taking a closer look tomorrow. |
vbarua
left a comment
There was a problem hiding this comment.
Left some minor comments, but looks good overall.
|
Thanks for the review! |
|
CONCAT simplification is merged 🙂 |
Assisted-by: gpt-5.6-sol (OpenAI Codex)
bca194f to
ebbfe8a
Compare
|
@vbarua rebased on main and addressed all review comments. Ready for another look when you have a chance. Thanks! |
|
@vbarua, gentle follow-up when you have a chance :) |
vbarua
left a comment
There was a problem hiding this comment.
Changes look good. Thanks for work on this 🙇
|
@alexandrefimov as a follow-up, if you wanted to make it easier to use the observer you've added, you could add it as a configurable setting in ConverterProvider.Builder |
|
Thanks! |
Summary
ConverterProviderwhile keeping the default conversion path unchangedRelated to #379.
Behavior
RexNodecontinues to use the type supplied by SubstraitCONCATproduces one observation for the complete invocationThis PR intentionally covers scalar functions only. Window functions, field references, and aggregate functions remain separate follow-up work.
Validation
./gradlew build --rerun-tasksCONCATAssisted-by: gpt-5.6-sol (OpenAI Codex)