Skip to content

chore: update to substrait v0.57.0#300

Merged
vbarua merged 4 commits into
substrait-io:mainfrom
kadinrabo:kadin.rabo/update-substrait-0.57.0
Oct 4, 2024
Merged

chore: update to substrait v0.57.0#300
vbarua merged 4 commits into
substrait-io:mainfrom
kadinrabo:kadin.rabo/update-substrait-0.57.0

Conversation

@kadinrabo

Copy link
Copy Markdown
Contributor
  1. Upgrade submodule to 0.57
  2. Update conversion visitors to handle new set op types (708) SET_OP_MINUS_PRIMARY_ALL & SET_OP_INTERSECTION_MULTISET_ALL
  3. Does not address the new grouping behavior in AggregateRel #299

chore(release): 0.57.0
ci: bump semantic-release to 24.1.2 (#718)
chore(deps): Bump bufbuild/buf-setup-action from 1.42.0 to 1.43.0 (#717)
feat: make substrait repo a go module (#712)
feat: clarify behaviour of SetRel operations (#708)
feat: change grouping expressions in AggregateRel to references (#706)
chore(deps): Bump bufbuild/buf-setup-action from 1.41.0 to 1.42.0 (#709)

@vbarua vbarua self-requested a review October 2, 2024 23:01

@vbarua vbarua left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Just have 2 minor changes I would like to see, but other than that this looks good to merge.

Comment thread isthmus/src/test/java/io/substrait/isthmus/utils/SetUtils.java
@kadinrabo kadinrabo requested a review from vbarua October 4, 2024 13:29
Comment thread isthmus/src/main/java/io/substrait/isthmus/SubstraitRelNodeConverter.java Outdated
@vbarua vbarua force-pushed the kadin.rabo/update-substrait-0.57.0 branch from f4723f7 to 413fede Compare October 4, 2024 15:36

@vbarua vbarua left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this!

@vbarua vbarua merged commit eb484a3 into substrait-io:main Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants