Fixes #23, install Reports to help ProfM track student health - #24
Merged
mmarum-sugarcrm merged 1 commit intoFeb 8, 2018
Merged
Conversation
lschaefer-sugarcrm
suggested changes
Feb 6, 2018
lschaefer-sugarcrm
left a comment
lschaefer-sugarcrm
left a comment
Contributor
There was a problem hiding this comment.
These reports look really nice! A couple of suggestions...
- The new API calls in Postman are in the Create Quotes category. We probably want them in their own category so people can find them.
- The new API calls don't have any tests associated with them.
- We probably want to update the doc to let people know these reports exist.
mmarum-sugarcrm
force-pushed
the
Issue-23
branch
from
February 7, 2018 02:54
41d1dba to
be17db5
Compare
Member
Author
|
@lschaefer-sugarcrm I've made updates. It should be good to go now. |
lschaefer-sugarcrm
approved these changes
Feb 7, 2018
lschaefer-sugarcrm
left a comment
lschaefer-sugarcrm
left a comment
Contributor
There was a problem hiding this comment.
I left two comments on the doc. The report functionality is great, so I'm marking this as approved. Not merging to allow for doc updates.
| # Student Health Tracking | ||
|
|
||
| When doing battle against the forces of evil, it is possible that a coder is incapacitated by carpal tunnel syndrome or even killed in a freak hoverboard accident. Professor M needs to report on the cause of death of any coder who has died in order to prevent the same mistakes from happening again. | ||
| When doing battle against the forces of evil, it is possible that a coder is incapacitated by carpal tunnel syndrome or even killed in a freak hoverboard accident. Professor M needs to keep track on the health of his students to make sure they are happy and productive and stay out of danger. |
Contributor
There was a problem hiding this comment.
typo: keep track of
| When `deceased` is selected, a new Death Information panel appears on the Record view and users are required to enter a Cause of Death (`cause_of_death_c`). | ||
|
|
||
| Professor M can then build reports based upon vital status and the common causes of death. | ||
| Two reports in a dev instance and then exported via REST API. These reports are then added to the Prof M. data collection. These reports rely primarily on `vital_c` and `cause_of_death_c` fields. |
Contributor
There was a problem hiding this comment.
This sentence doesn't make sense to me: Two reports in a dev instance and then exported via REST API.
mmarum-sugarcrm
force-pushed
the
Issue-23
branch
from
February 7, 2018 16:55
be17db5 to
af275f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a couple reports to the data import Postman collection.