fix: sync Cargo.lock and self-heal it in ci.yml - #46
Merged
Conversation
PR #45's checks failed on msrv: main's Cargo.lock was still at forgeguard 0.11.1 while Cargo.toml is 0.11.2 (from PR #43) - same drift class as #35, #40, #44, just hitting ci.yml this time instead of release.yml. ci.yml runs on every push/PR to main, so this will keep breaking the very next push after every release-please merge until CI stops depending on Cargo.lock already being correct. - Cargo.lock: synced forgeguard's entry to 0.11.2 (immediate fix, verified locally: cargo build --workspace and cargo check --locked --workspace both clean afterward). - ci.yml: added the same `cargo update -p forgeguard` self-heal used in release.yml (#44) to both msrv and quality, explicitly, rather than relying on quality's clippy step happening to regenerate the lock file as an accidental side effect before its own --locked steps run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
msrvcheck failed the same way v0.11.1'sReleasebuild did:cargo check --lockedrefused becauseCargo.lockwas still pinned toforgeguard 0.11.1whileCargo.tomlon main is already0.11.2(from PR chore(main): release 0.11.2 #43 merging). Same drift class as fix: repair release-please pipeline and enable npm publish #35, fix: chain Release workflow into release-please #40, fix: self-heal Cargo.lock in Release instead of depending on release-please #44 — this time hittingci.yml(runs on every push/PR to main) instead ofrelease.yml.release.yml,ci.ymlhas no self-heal yet, so this will keep breaking the very first push/PR after every future release-please merge, indefinitely.Changes
Cargo.lock: syncedforgeguard's entry to0.11.2. Verified locally:cargo build --workspaceandcargo check --locked --workspaceboth clean afterward..github/workflows/ci.yml: addedcargo update -p forgeguard(same self-heal approach as fix: self-heal Cargo.lock in Release instead of depending on release-please #44) to bothmsrvandquality, explicitly —qualityhappened to survive so far only becausecargo clippy(no--locked) runs before its--lockedsteps and silently regenerates the lock file as a side effect; making it explicit removes the reliance on that incidental ordering.Test plan
cargo build --workspacecleancargo check --locked --workspaceclean.github/workflows/ci.ymlvalidated as well-formed YAMLmsrv/qualitychecks pass