Skip to content

Wrong translation key in aria-label="Visionouvelle fenêtre" #2019

@virgile-dev

Description

@virgile-dev

Bug Report

Problematic behavior
The translation key for the aria-label content is not right. It was added in #1984

Curently we have this aria-label="Visionouvelle fenêtre"
The translation key is set like this newWindowLabelSuffix={t('new window')}

Expected behavior/code
We should have aria-label="Visio (nouvelle fenêtre)"

The translation key should be `newWindowLabelSuffix={t(' (new window)')}
I included the space between Visio and (nouvelle fenêtre) . I don't know if it's a good practice.

Steps to Reproduce

  1. Do this...
  2. Then this...
  3. And then the bug happens!

Environment

  • Docs version: 4.8
  • Instance url: docs.numerique.gouv.fr

Possible Solution

Additional context/Screenshots
Add any other context about the problem here. If applicable, add screenshots to help explain.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions