Merged
Conversation
|
Size Change: +171 B (0%) Total Size: 4.24 MB
|
AntoLC
force-pushed
the
feat/hint-typing-search
branch
from
8c45fa6 to
af20e10
Compare
Ovgodd
requested changes
Mar 20, 2026
Collaborator
Ovgodd
left a comment
Ovgodd
left a comment
There was a problem hiding this comment.
Just a suggestion for a better accessibility :D
|
|
||
| return t('Choose a user'); | ||
| }, [minLength, searchUsersRawData?.length, t, userQuery]); | ||
|
|
Collaborator
There was a problem hiding this comment.
Can you add announce() from @react-aria/live-announcer so the search hint ("Type at least X characters...", "Choose a user", etc.) is announced by screen readers when it changes.
Suggested change
| useEffect(() => { | |
| announce(hint, 'polite'); | |
| }, [hint]); |
AntoLC
force-pushed
the
feat/hint-typing-search
branch
from
af20e10 to
ac78be7
Compare
AntoLC
force-pushed
the
feat/hint-typing-search
branch
from
ac78be7 to
6adc081
Compare
We give a hint to the user about the minimum number of characters required to perform a search in the quick search input of the doc share modal. This is to improve the user experience.
AntoLC
force-pushed
the
feat/hint-typing-search
branch
from
6adc081 to
fb92a43
Compare
lunika
added a commit
that referenced
this pull request
Mar 25, 2026
Added - 🚸(frontend) hint min char search users #2064 Changed - 💄(frontend) improve comments highlights #1961 - ♿️(frontend) improve BoxButton a11y and native button semantics #2103 - ♿️(frontend) improve language picker accessibility #2069 - ♿️(frontend) add aria-hidden to decorative icons in dropdown menu #2093 Fixed - 🐛(y-provider) destroy Y.Doc instances after each convert request #2129 - 🐛(backend) remove deleted sub documents in favorite_list endpoint #2083
lunika
added a commit
that referenced
this pull request
Mar 25, 2026
Added - 🚸(frontend) hint min char search users #2064 Changed - 💄(frontend) improve comments highlights #1961 - ♿️(frontend) improve BoxButton a11y and native button semantics #2103 - ♿️(frontend) improve language picker accessibility #2069 - ♿️(frontend) add aria-hidden to decorative icons in dropdown menu #2093 Fixed - 🐛(y-provider) destroy Y.Doc instances after each convert request #2129 - 🐛(backend) remove deleted sub documents in favorite_list endpoint #2083
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
We give a hint to the user about the minimum number of characters required to perform a search in the quick search input of the doc share modal.
This is to improve the user experience.
Demo
Enregistrement.2026-03-18.113601.mp4