Skip to content

♿️(frontend) improve language picker accessibility#2069

Merged
Ovgodd merged 1 commit intomainfrom
fix/language-picker-accessibility
Mar 25, 2026
Merged

♿️(frontend) improve language picker accessibility#2069
Ovgodd merged 1 commit intomainfrom
fix/language-picker-accessibility

Conversation

@Ovgodd
Copy link
Collaborator

@Ovgodd Ovgodd commented Mar 18, 2026

Purpose

Improve accessibility of the language picker for screen reader users.

Proposal

  • Use menuitemradio and aria-checked to announce selected state (checked/unchecked)
  • Add lang attribute on language labels for correct pronunciation
  • Add aria-live region to announce language change when confirming selection

@Ovgodd Ovgodd requested a review from AntoLC March 18, 2026 11:16
@Ovgodd Ovgodd self-assigned this Mar 18, 2026
@Ovgodd Ovgodd force-pushed the fix/language-picker-accessibility branch 4 times, most recently from 0910873 to b82bb54 Compare March 18, 2026 11:21
@Ovgodd Ovgodd marked this pull request as ready for review March 18, 2026 11:21
@Ovgodd Ovgodd linked an issue Mar 18, 2026 that may be closed by this pull request
@Ovgodd Ovgodd moved this from Backlog to In review in LaSuite Docs A11y Mar 18, 2026
@Ovgodd Ovgodd force-pushed the fix/language-picker-accessibility branch 5 times, most recently from afb7b47 to f19bdb7 Compare March 18, 2026 13:12
@github-actions
Copy link

github-actions bot commented Mar 18, 2026

Size Change: +106 B (0%)

Total Size: 4.24 MB

Filename Size Change
apps/impress/out/_next/static/6be3c002/_buildManifest.js 622 B +622 B (new file) 🆕
apps/impress/out/_next/static/db99e7b9/_buildManifest.js 0 B -622 B (removed) 🏆

compressed-size-action

@Ovgodd Ovgodd force-pushed the fix/language-picker-accessibility branch 9 times, most recently from abab17b to 50ddc6a Compare March 23, 2026 07:52
@Ovgodd Ovgodd force-pushed the fix/language-picker-accessibility branch 2 times, most recently from 9268107 to 03f41e0 Compare March 24, 2026 16:00
@Ovgodd Ovgodd force-pushed the fix/language-picker-accessibility branch 2 times, most recently from f7884ff to 42f56a5 Compare March 25, 2026 09:43
Add missing attributes for language picker.
@Ovgodd Ovgodd force-pushed the fix/language-picker-accessibility branch from 42f56a5 to c886cbb Compare March 25, 2026 10:08
@Ovgodd Ovgodd merged commit c886cbb into main Mar 25, 2026
26 of 27 checks passed
@Ovgodd Ovgodd deleted the fix/language-picker-accessibility branch March 25, 2026 10:49
@github-project-automation github-project-automation bot moved this from In review to Done in LaSuite Docs A11y Mar 25, 2026
lunika added a commit that referenced this pull request Mar 25, 2026
Added

- 🚸(frontend) hint min char search users #2064

Changed

- 💄(frontend) improve comments highlights #1961
- ♿️(frontend) improve BoxButton a11y and native button semantics #2103
- ♿️(frontend) improve language picker accessibility #2069
- ♿️(frontend) add aria-hidden to decorative icons in dropdown menu #2093

Fixed

- 🐛(y-provider) destroy Y.Doc instances after each convert request #2129
- 🐛(backend) remove deleted sub documents in favorite_list endpoint #2083
lunika added a commit that referenced this pull request Mar 25, 2026
Added

- 🚸(frontend) hint min char search users #2064

Changed

- 💄(frontend) improve comments highlights #1961
- ♿️(frontend) improve BoxButton a11y and native button semantics #2103
- ♿️(frontend) improve language picker accessibility #2069
- ♿️(frontend) add aria-hidden to decorative icons in dropdown menu #2093

Fixed

- 🐛(y-provider) destroy Y.Doc instances after each convert request #2129
- 🐛(backend) remove deleted sub documents in favorite_list endpoint #2083
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Icons secondary navigation (top / right of the screen)

2 participants