Skip to content

馃悰(lagaufre) trigger clickOutside event during capture phase - #55

Merged
jbpenrath merged 1 commit into
mainfrom
fix/gaufre-close-listener
Jun 11, 2026
Merged

馃悰(lagaufre) trigger clickOutside event during capture phase#55
jbpenrath merged 1 commit into
mainfrom
fix/gaufre-close-listener

Conversation

@jbpenrath

Copy link
Copy Markdown
Contributor

Currently, the event triggered when the user clicks outside lagaufre is triggered during bubble phase. That means that if some other components use stopPropagation in their click listeners our event is not triggered and lagaufre stays opened..

Currently, the event triggered when the user clicks outside
lagaufre is triggered during bubble phase. That means that if
some other components use stopPropagation in their click listeners
our event is not triggered and lagaufre stays opened..
@jbpenrath jbpenrath self-assigned this Jun 10, 2026
jbpenrath added a commit to suitenumerique/messages that referenced this pull request Jun 10, 2026
UI-Kit expose LaGaufreV2 component we can now remove our custom
implementation and use this component instead.
Note: There is currently a bug that prevent to close lagaufre when
we open a Dropdown menu. We implement a quick fix here that must be
removed once suitenumerique/integration#55
will be merged
@sylvinus

Copy link
Copy Markdown
Member

Good catch

@jbpenrath
jbpenrath merged commit 5316093 into main Jun 11, 2026
3 of 4 checks passed
@jbpenrath
jbpenrath deleted the fix/gaufre-close-listener branch June 11, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants