refactor: remove AI slop - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: remove AI slop
Removes unused imports (dead code) across the pipeline-service. Pure deletions of imports that have no references anywhere in the codebase — no logic, behavior, or public API changes.
Scope
Behavior-preserving cleanup only. No dependency, workflow, lockfile, or test changes.
Changes
Removed unused imports detected via AST scan and verified by grep:
pipeline-service/config/settings.pyfrom typing import Optional,import ospipeline-service/database.pyfrom models.customer import Customerinsideinit_db()(unused local import)pipeline-service/main.pyOptionalfrom typing import,from models.customer import Customerpipeline-service/services/ingestion.pyList,Optionalfrom typing importpipeline-service/services/pipeline.pyList,Optionalfrom typing importpipeline-service/sinks/postgres_sink.pyfrom database import get_db,from datetime import datetime, timezonepipeline-service/sources/base.pyOptionalfrom typing importWhat was preserved
__init__.pyre-exports — intentional public API surface (consumers import from package roots).bulk_create,get_or_create,fetch_paginated,get_pipeline_status) — these are part of the framework's public API surface, not dead code.except Exceptionblocks invalidate()methods onHTTPSource/PostgresSinkand the orchestrator'sexecute()— these are I/O / top-level boundaries that intentionally convert any failure to a boolean /IngestResponse.importstatements inside endpoint handlers — lazy-loading pattern, not slop.Verification
pytest tests/test_unit/ tests/test_integration/→ 28 passed, 0 failedpytest tests/test_unit/ tests/test_integration/→ 28 passed, 0 failed