Parametrize the inherited TestStackLikeFunctions in the vector tests#185
Merged
Conversation
named-arrays now exercises np.stack against a second array in TestStackLikeFunctions (sun-data/named-arrays#191), which requires each family test module to parametrize array_2. Mirror the existing TestAsArrayLikeFunctions pattern in the optika vector and ray test modules. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lm9SxSpyNg9hx8dNL9pUXc
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Lm9SxSpyNg9hx8dNL9pUXc
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #185 +/- ##
=======================================
Coverage 99.37% 99.37%
=======================================
Files 116 116
Lines 6257 6275 +18
=======================================
+ Hits 6218 6236 +18
Misses 39 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
named-arrays now exercises
np.stackagainst a second operand in the genericTestStackLikeFunctions(sun-data/named-arrays#191, released in the latest named-arrays version), which requires each family test module to parametrizearray_2. Without this, the optika vector/ray test classes that inherit the named-arrays abstract test chains error with "fixture 'array_2' not found" (16 errors against the new release).This mirrors the existing
TestAsArrayLikeFunctionspattern in the six affected modules (test_vectors_field/object/polarization/pupil/scene,test_ray_vectors), reusing each module's existing instance lists. 28 new stack cases pass;blackandruffclean.🤖 Generated with Claude Code
https://claude.ai/code/session_01Lm9SxSpyNg9hx8dNL9pUXc