Skip to content

release: v4.2.2#287

Merged
Svtter merged 1 commit into
mainfrom
release/v4.2.2
Jun 27, 2026
Merged

release: v4.2.2#287
Svtter merged 1 commit into
mainfrom
release/v4.2.2

Conversation

@Svtter

@Svtter Svtter commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

Version bump only. Per docs/release-process.md, no tag is created in this PR — the v4.2.2 tag is cut locally on main after this merges.

Changes

  • multi-review/package.json: 4.2.14.2.2
  • CHANGELOG.md: release [Unreleased] as [4.2.2] - 2026-06-27, fresh empty [Unreleased] on top.

What's in 4.2.2

Patch release — single bugfix from #286:

Fixed

  • multi-review: retry transient reviewer failures (undici fetch failed wiping long-running reviewers) with deadline-aware, jittered exponential backoff. Fresh session per attempt; reviewer's own deadline timeout excluded; non-transient errors fail immediately. Failed attempts always tear down their session even under skipSessionCleanup.

Not touched

  • setup-opencode/default-version (1.14.30) — opencode CLI min-version, not the action version.

Post-merge (manual, on main)

```bash
git fetch origin main
git tag -a v4.2.2 -m "Version 4.2.2

multi-review: retry transient reviewer failures with deadline-aware jittered backoff (#286)."
git push origin v4.2.2
```
Then the verification PR + GitHub Release per the release process.

### Fixed
- multi-review: retry transient reviewer failures (undici fetch failed
  on long-running reviewers) with deadline-aware, jittered exponential
  backoff. PR #286.
@Svitter Svitter added chore Maintenance, tooling, and config changes cli CLI tooling and scripts review:p0 Critical review findings triaged Issue has been triaged labels Jun 27, 2026

@Svitter Svitter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 — lgtm, merge on a glance.

Version bump (4.2.14.2.2) with a properly formatted CHANGELOG entry for the retry-transient-fix merged in #286. Two files changed, zero behavioral changes in this PR — exactly what a release-process bump should be.

Checked:

  • multi-review/package.json: version matches the CHANGELOG heading.
  • CHANGELOG.md: new [4.2.2] - 2026-06-27 section under ### Fixed, fresh [Unreleased] with _Nothing yet._ on top — matches repo convention (see v4.2.1, v4.2.0 entries above).
  • setup-opencode/default-version not touched — correct per AGENTS.md (that file is opencode CLI min-version, not the action version).

No findings. The release process post-merge steps (tag, verification PR, GitHub Release) are documented in the PR body. Thank you, @Svtter.

@github-actions

Copy link
Copy Markdown

✅ 可合并 / CAN MERGE

所有 6 位 reviewer 均无阻塞项。该 PR 仅包含版本号升级(4.2.1 → 4.2.2)和 CHANGELOG 记录,无任何代码变更。

🟡 警告项 / Warnings (1)

  • skipSessionCleanup 行为变更(security reviewer)— CHANGELOG 提到失败的尝试现在总是清理 session(不再保留半完成 session),这是破坏性变更。若外部系统依赖旧行为进行审计或合规,存在数据丢失风险。建议确认是否有用户依赖此旧行为,并在 CHANGELOG 中明确标注为 BREAKING CHANGE。
💰 Review Cost — $0.0000
Role Cost (USD) Input Output Reasoning Cache Read Cache Write
quality $0.0000 8,809 76 277 0 0
security $0.0000 8,818 185 92 0 0
performance $0.0000 9,117 72 83 0 0
architecture $0.0000 8,822 66 338 0 0
regression-test $0.0000 28,474 395 726 0 0
test-value $0.0000 8,949 33 293 0 0
coordinator $0.0000 9,099 184 216 0 0
Total $0.0000 82,088 1,011 2,025 0 0
📋 各 Reviewer 详细审查结果
quality

可合并 / CAN MERGE

仅包含版本号升级(4.2.1 → 4.2.2)和 CHANGELOG 更新,变更内容清晰规范,符合 semver patch 版本规则。

阻塞项:无
警告项:无
建议项:无

security

存在风险 / AT RISK

本次 PR 仅包含版本号升级(4.2.1 → 4.2.2)和 CHANGELOG 更新,不涉及任何代码变更。CHANGELOG 描述了关于多 reviewer 重试逻辑的行为调整(重试临时网络错误、指数退避、deadline 感知等),但这些逻辑的实现代码不在本次 diff 中,无法进行安全审查。

阻塞项:无

警告项:

  1. CHANGELOG 提到 skipSessionCleanup 行为变更——失败的尝试现在总是清理 session。这是一个破坏性行为变更,可能影响依赖旧行为(保留半完成 session 用于导出)的用户。这更多属于兼容性问题而非安全问题,但如果外部系统依赖于这些 session 进行审计或合规用途,则存在数据丢失风险。

建议项:无

performance

性能良好 / GOOD

该 PR 仅包含 CHANGELOG.md 更新和 package.json 版本号变更,无任何代码改动。因此不存在算法效率、内存泄漏、数据库查询、缓存、并发或资源利用等方面的性能问题。

阻塞项:无
警告项:无
建议项:无

architecture

架构合理 / SOUND

此 PR 仅包含版本号升级和 CHANGELOG 记录,无实际代码变更,不存在架构问题。

阻塞项:无
警告项:无
建议项:无

regression-test

无需回归测试 / NO REGRESSION TESTS NEEDED

PR 类型:CHORE(仅版本号更新和 CHANGELOG 记录)

分析:

  • 该 PR 的 diff 仅包含 CHANGELOG.md(记录修复内容)和 multi-review/package.json(版本号 4.2.1 → 4.2.2)的变更。
  • PR diff 中不包含任何源代码或测试文件的改动。
  • 重试逻辑的实现在此前已经存在于 multi-review/src/orchestrator.ts 中(isTransientReviewerError、指数退避、deadline-aware 重试、jitter、session 清理等)。
  • 对应的回归测试已完整覆盖在 multi-review/src/orchestrator.test.ts 中(621 行),包含:
    • 瞬态错误重试并在新 session 上恢复成功(第 284 行)
    • 持续瞬态错误耗尽最大重试次数后失败(第 339 行)
    • 非瞬态错误不重试(第 377 行)
    • 恢复已有 session 后瞬态失败,丢弃并重试新 session(第 410 行)
    • skipSessionCleanup=true 时失败 session 仍被清理(第 471 行)
    • 自身 deadline timeout 不重试(第 513 行)
    • session 管理、cleanupAllSessions 幂等性等

由于该 PR 本身仅做发布准备(版本号 + 变更记录),不涉及任何行为修改,因此无需新增回归测试。

阻塞项:无
警告项:无
建议项:无

test-value

测试全部有价值 / ALL TESTS HAVE VALUE

阻塞项:无

警告项:无

建议项:无

@Svtter
Svtter merged commit 0ddf321 into main Jun 27, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Maintenance, tooling, and config changes cli CLI tooling and scripts review:p0 Critical review findings triaged Issue has been triaged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants