[core][rest] Refine filtered partition listing and tests - #3
Merged
sundapeng merged 1 commit intoJul 22, 2026
Conversation
sundapeng
commented
Jul 22, 2026
| private final boolean dataTokenEnabled; | ||
| protected final Map<String, String> tableDefaultOptions; | ||
| private final @Nullable LocalCacheManager cacheManager; | ||
| private volatile FilteredPartitionListingSupport filteredPartitionListingSupport = |
sundapeng
commented
Jul 22, 2026
| return page; | ||
| } catch (NoSuchResourceException e) { | ||
| throw new TableNotExistException(identifier); | ||
| if (!canFallbackToPlainPartitionListing(pageToken)) { |
sundapeng
commented
Jul 22, 2026
| } | ||
| } | ||
|
|
||
| private boolean canFallbackToPlainPartitionListing(@Nullable String pageToken) { |
sundapeng
commented
Jul 22, 2026
| return page; | ||
| } | ||
|
|
||
| private enum FilteredPartitionListingSupport { |
sundapeng
commented
Jul 22, 2026
|
|
||
| /** Bounds one request: catalog services cap the partitions a single call may carry. */ | ||
| private static final int REQUEST_SIZE = 1000; | ||
| private static final int PARTITION_PAGE_SIZE = 1000; |
sundapeng
commented
Jul 22, 2026
| */ | ||
| private static boolean indicatesNoFilterListing(Exception exception) { | ||
| return exception instanceof UnsupportedOperationException | ||
| || exception instanceof Catalog.TableNotExistException; |
sundapeng
force-pushed
the
fix/format-table-partition-filter-review
branch
from
July 22, 2026 02:43
5249027 to
a371441
Compare
sundapeng
changed the title
sundapeng
merged commit Jul 22, 2026
aaf9bb4
into
format-table-partition-filter-rest-api
25 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up cleanup for
apache/paimon#8785. It simplifies filtered partition listing, preserves paged REST responses, and strengthens the related tests.Changes
Catalogdefault filtered listing delegate to plain paged listing as a candidate superset.CatalogFormatTablePartitionManageruse the catalog contract directly without its own exception fallback.nextPageTokenwhen a filtered REST response contains null partitions.Testing
git diff --checkpassed.