feat(index): show per-phase progress with elapsed time#32
Merged
Conversation
The index progress bar previously only covered the file-scanning phase and wiped its elapsed time on finish; all post-scan phases (persisting nodes/ edges/refs, framework detection, reference resolution, post-extract, compaction) ran silently. On large repos the resolve phase dominates, leaving the user staring at a blank terminal. Add a labeled phase spinner around each phase that retains a "checkmark label (elapsed)" line on stderr, and keep the scan elapsed instead of clearing it. Progress stays a pure side effect: hidden on --quiet and non-TTY, stderr-only, stdout untouched, golden byte-equivalence preserved. Also fix sync dropping its scan elapsed on finish.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The index progress bar previously only covered the file-scanning phase and wiped its elapsed time on finish; all post-scan phases (persisting nodes/edges/refs, framework detection, reference resolution, post-extract, compaction) ran silently. On large repos the resolve phase dominates, leaving the user staring at a blank terminal.
This adds a labeled phase spinner around each phase that retains a
✓ <label> (<elapsed>)line on stderr, and keeps the scan elapsed instead of clearing it. Progress stays a pure side effect: hidden on--quietand non-TTY, stderr-only, stdout untouched, golden byte-equivalence preserved. Sync's dropped scan elapsed is fixed too.Verified: golden byte-equivalence 11/11 + 4/4, full
cargo test --workspacegreen, clippy/fmt/guardrail 0, hands-on TTY shows all 8 phase lines with elapsed, piped 0 carriage-returns,--quiet0 bytes both streams, DB counts stable.