fix(daemon): reap detached daemon child to avoid zombie#80
Merged
Conversation
- keep a reaper thread that wait()s the spawned child instead of dropping it - setsid alone does not relieve a long-lived parent from reaping its child - add a Unix regression test asserting no zombie child remains
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spawn_detached_daemonpreviously dropped the spawnedChildhandle, so when the parentserve --mcpproxy stayed alive long-term, the exited daemon child became a[codegraph] <defunct>zombie holding a process-table slot.setsid()only detaches the daemon's session/process group; it does NOT relieve a still-live parent from its duty towait()the child. The fix keeps a tiny reaper thread thatwait()s the child.spawn_detached_daemon_reaps_exited_childthat asserts no zombie child remains after a short-lived spawn.Verification
make cigreen locally (fmt + clippy + test + guardrail)drop(child)code, passes after the reaper-thread fixserve --mcpwith an exiting daemon child, parent alive → process table shows noZchild (QA_RESULT=no-zombie)