WIP - Sunny/pipelines by sunny2get · Pull Request #1 · sunny2get/cli

sunny2get · 2026-04-30T03:45:09Z

RATIONALE

CHANGES

PR Automation

Comment-Commands: Trigger CI by commenting on the PR:

/trigger-smoke-test or /trigger-test-smoke - Run smoke tests
/trigger-install-test or /trigger-test-install - Run installation tests

Labels: Apply labels to trigger workflows:

run-smoke-tests or go - Run smoke tests on demand (only works for non-forked PRs)

Important

For Forked PRs: The run-smoke-tests label won't work. A required Smoke Tests check will block merge until a maintainer acts:

A maintainer uses /approve-smoke-tests to run smoke tests (results will set the check)
A maintainer uses /skip-smoke-tests to bypass the check without running tests

Please comment requesting a maintainer review if you need smoke tests to run.

ajalon1

Some very nice work so far. I'm looking at this from a very high level, mostly in regards to:

general implementation as an API client
implementation patterns that dovetail with the overall CLI, or can be used to improve the overall CLI

Obviously not a comprehensive review.

The only thing I would actually require as a change would be to rename the command to "pipeline" and permit "pipelines" as an alias.

ajalon1 · 2026-05-04T16:26:54Z

+
+func Cmd() *cobra.Command {
+	cmd := &cobra.Command{
+		Use:     "pipelines",


Suggested change

Use: "pipelines",

Use: "pipeline",

Aliases: []string{"pipelines"},

to keep things consistent in CLI help.

ajalon1 · 2026-05-04T16:28:58Z

@@ -0,0 +1,178 @@
+<!-- TOOD: remove this file, just to keep track internally while development is happening -->


I appreciate this reference here. These summary docs really help when reviewing large PRs like this.

ajalon1 · 2026-05-04T16:45:56Z

+
+	flags.Bind(cmd)
+	cmd.Flags().IntVar(&offset, "offset", 0, "Pagination offset")
+	cmd.Flags().IntVar(&limit, "limit", 0, "Maximum number of inputs to return")


I noticed limit default of 0 in a lot of the list commands. I would expect that all of the list commands have a defined default limit -- it's just good practice for any API client.

ajalon1 · 2026-05-04T16:47:58Z

+			if pipelineID == "" {
+				return errors.New("--pipeline is required")
+			}


You can use MarkFlagRequired() to not have to reimplement this yourself.

ajalon1 · 2026-05-04T16:51:42Z

+// Flags holds the values backing the shared --pipeline / --scope /
+// --version flags. Bind() registers them on a cobra command and
+// Resolve(cmd) turns them into a (Scope, *version) pair via
+// pipelines.ResolveScope.
+type Flags struct {
+	PipelineID string
+	Scope      string
+	Version    int
+}


I actually really like this pattern. I wonder if it's possible for this to be used more consistently throughout the pipeline commands.

ajalon1 · 2026-05-04T16:56:32Z

+func TestHandleDeleteError_404IsSuppressed(t *testing.T) {
+	httpErr := &drapi.HTTPError{StatusCode: http.StatusNotFound, URL: "http://x/api/v2/pipelines/abc"}
+
+	err := handleDeleteError(httpErr, "abc")
+	assert.NoError(t, err)
+}


Why do you return an error on 404 for some commands, and suppress it for others?

ajalon1 · 2026-05-04T16:57:16Z

+
+	if d.VersionID != nil {
+		scope = "locked"
+		versionDisplay = "v" + strconv.Itoa(*d.VersionID)


Why have the extra v?

…oss#522) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Co-authored-by: Copilot <copilot@github.com>

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>

- Replace UUID IDs with 24-char MongoDB ObjectIds in help text, test fixtures, and docs (pipeline_id, dispatch_id, input_id, schedule_id, environment_id now use ObjectId format per pipelines-api commit 65c86cd) - Add internal/pipelines/Time type with flexible UnmarshalJSON to handle the API's bare UTC datetime strings (no timezone suffix) alongside standard RFC3339, fixing the time-parse crash on pipelines list/get - Update Graph structs: GraphNode.ID and GraphEdge.Source/Target are now int (not string), GraphPipeline drops ID, adds PythonVersion; add extra edge/node fields for full --output json pass-through - Fix demo-pipelines Taskfile target to use correct port 8100 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Covalent is not available in the local port-forward environment, so environment create/update time out. Mirrors the existing SKIP_SCHEDULES flag. Both default to false; pass SKIP_ENVIRONMENTS=true to skip the 8 environment steps (total drops to 27 when combined with SKIP_SCHEDULES). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

API now returns RFC3339Nano timestamps with Z suffix, so the custom pipeline.Time wrapper is no longer needed. Replace all Time fields in pipeline.go with standard time.Time and delete time.go. Also default DEMO_SKIP_SCHEDULES and DEMO_SKIP_ENVIRONMENTS to true in the demo-pipelines Taskfile task (k8s/Covalent not available locally), and pipe demo output to output.txt via tee. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

API is now RFC3339 compliant; replace string datetime fields with time.Time across run, input, schedule, and environment structs. Update render helpers to format with .UTC().Format(time.RFC3339), consistent with the pipeline/version commands. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

- Add cmd/pipelines/outputfmt: OutputFormat type + AddOutputFlag() with --output-format flag, mirroring internal/workload/flags.go - Add cmd/pipelines/pipelineutil: RenderPipeline/RenderPipelines with lipgloss/table list view and tabwriter detail view - Rewrite all *util/render.go files: add Render*() routing functions, replace tabwriter lists with lipgloss/table, switch to tabwriter for detail views, add DTOs for input/schedule/environment/version, adopt "2006-01-02 15:04 UTC" timestamp format - Update all 23 verb cmd files: use outputfmt.AddOutputFlag, remove scattered --output StringVar and manual validation, call Render*() Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…pattern Consolidates all *util sibling packages (runutil, inpututil, scheduleutil, envutil, versionutil, pipelineutil, outputfmt) into internal/pipelines/, mirroring how internal/workload/ owns its own output helpers. Each cmd verb now imports only internal/pipelines and calls e.g. pipelines.RenderRuns(). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…-056 - camelCase all JSON tags to match DrBaseModel alias_generator (action 056) - Primary resource IDs now decode as "id" on the wire - Wrap all list endpoints in DataPage[T] envelope (action 056) - Remove PipelineName (lattice_name) from PipelineVersion — dropped by action 055 - Rename electron_names → taskNames, python_version → pythonVersion, etc. - Update all test mock responses and DataPage[ListItem] in list cmd tests - Fix pre-existing invalid "t" timestamps in environment_test.go Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Renames cmd/pipelines/ → cmd/pipeline/, updates the cobra Use field, feature gate key (DATAROBOT_CLI_FEATURE_PIPELINE), and all example strings. Adds "pipelines" as a backward-compat alias per naming conventions. Docs and demo.sh updated accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…lient Replace the duplicated inline token+header setup and &http.Client{} construction in Get, Post, Patch, and Delete with the AuthorizeRequest and NewHTTPClient helpers introduced in client.go. Also fixes a bug in Post/Delete where config.GetAPIKey was called directly, bypassing the --skip-auth flag. Migrates raw viper imports to viperx in get.go and affected test files to satisfy depguard. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…k and header consistency - Move AuthorizeRequest from client.go to auth.go (its natural home); remove the now-redundant SetAuthHeaders wrapper and update filesapi callers to call AuthorizeRequest directly - Fix --skip-auth bypass: auth.go previously called config.GetAPIKey directly, bypassing resolveToken(); now all callers go through getToken() which honours skip_auth - Fix GetJSON body leak: use defer resp.Body.Close() so body is closed on decode error - Fix Header.Add → Header.Set for Content-Type in delete.go, post.go, patch.go - Replace hand-rolled fakeBody (missing io.EOF) with strings.NewReader in client_test.go Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

pipelines-api action 059 renamed the graph JSON key from "lattice" to "pipeline" (PipelineGraphLattice → PipelineGraphMeta). Update the Go struct tag and test fixtures to match the new wire format. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Renames the Go package from `internal/pipelines` to `internal/pipeline` to match the singular command name (`dr pipeline`) and updates all cmd imports, tests, and telemetry calls accordingly. Also adds telemetry TrackWith calls across all pipeline subcommands. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

sunny2get changed the title ~~Sunny/pipelines~~ WIP - Sunny/pipelines May 4, 2026

ajalon1 reviewed May 4, 2026

View reviewed changes

sunny2get force-pushed the sunny/pipelines branch from 52f4751 to e1089f7 Compare May 20, 2026 17:34

dependabot Bot and others added 17 commits May 22, 2026 13:52

⬆️ sec(deps): Bump golang.org/x/sys from 0.44.0 to 0.45.0 (datarobot-…

0ca188b

…oss#522) Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

add pipelines command and its subcommands

a33a43f

Co-authored-by: Copilot <copilot@github.com>

update get command output error handling

4fa89b7

update to direct http calls

3142b78

updated create and update methods

86337aa

add tests

4ea21e7

add new commands to cover the rest of APIs

71f2496

add unit tests

4ab12ca

adding environment subcommand

c6031e1

update the commands to use new words-pipeline and task

f530683

update dispatch to run

0ac675c

remap run --output json to use run_id / covalent_run_id

785106a

Co-authored-by: factory-droid[bot] <138933559+factory-droid[bot]@users.noreply.github.com>

sunny2get force-pushed the sunny/pipelines branch from 2e6cc30 to 3d77d0f Compare May 22, 2026 21:14

sunny2get and others added 8 commits May 22, 2026 21:37

[CMPT-5391] fix variable shadowing in pipeline get command

4d50105

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Navigation Menu

WIP - Sunny/pipelines - #1

WIP - Sunny/pipelines#1
sunny2get wants to merge 25 commits into
mainfrom
sunny/pipelines

sunny2get commented Apr 30, 2026

Uh oh!

ajalon1 left a comment

Uh oh!

ajalon1 May 4, 2026

Uh oh!

ajalon1 May 4, 2026

Uh oh!

ajalon1 May 4, 2026

Uh oh!

ajalon1 May 4, 2026

Uh oh!

ajalon1 May 4, 2026

Uh oh!

ajalon1 May 4, 2026

Uh oh!

ajalon1 May 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	Use: "pipelines",
	Use: "pipeline",
	Aliases: []string{"pipelines"},

		@@ -0,0 +1,178 @@
		<!-- TOOD: remove this file, just to keep track internally while development is happening -->

Conversation

sunny2get commented Apr 30, 2026

RATIONALE

CHANGES

PR Automation

Uh oh!

ajalon1 left a comment

Choose a reason for hiding this comment

Uh oh!

ajalon1 May 4, 2026

Choose a reason for hiding this comment

Uh oh!

ajalon1 May 4, 2026

Choose a reason for hiding this comment

Uh oh!

ajalon1 May 4, 2026

Choose a reason for hiding this comment

Uh oh!

ajalon1 May 4, 2026

Choose a reason for hiding this comment

Uh oh!

ajalon1 May 4, 2026

Choose a reason for hiding this comment

Uh oh!

ajalon1 May 4, 2026

Choose a reason for hiding this comment

Uh oh!

ajalon1 May 4, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants