Add first attempt at a centralised update workflow - #288
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
GitHub Actions
Failure
ac05127 to
caaf5c0
Compare
GitHub Actions
Failure
GitHub Actions
Failure
GitHub Actions
Failure
c479b02 to
39b4a46
Compare
58befcc to
231ee04
Compare
c87da8c to
53abde5
Compare
9ac392a to
71f8159
Compare
| $([ "$DRAFT" = "true" ] && echo "--draft" || echo "")) | ||
| PR_NUMBER="${PR_URL##*/}" | ||
| echo "pr_number=$PR_NUMBER" >> "$GITHUB_OUTPUT" | ||
|
|
There was a problem hiding this comment.
Could add another step in here to add labels (no changelog? minor change?)
There was a problem hiding this comment.
This workflow doesn't have the permissions to do that.
71f8159 to
304d37d
Compare
|
#290 is an example of the issue opened if a job fails |
alasdairwilson
left a comment
alasdairwilson
left a comment
There was a problem hiding this comment.
I dont think you need to make any changes, the thing is so complex...I wouldn't want to start rooting around in it and forcing another 12 iterations to get it working again.
| id: cruft_json | ||
| run: | | ||
| git status --porcelain=1 | ||
| if [[ "$(git status --porcelain=1)" == " M .cruft.json" ]]; then |
There was a problem hiding this comment.
What does this do? considering you later disregard if the diff is empty, there is a LOT of further steps that are using this return so, assumning that the reason you use a later check is because this was submitting blank commits....U suspect that this is returning has_changes = 1 even if there aren't any.
There was a problem hiding this comment.
The idea of this task is that if only .cruft.json has been updated (i.e. just the commit has revved but there are no changes) then we stop.
|
I'm going to merge this and we can fix up stuff incrementally. |
3 participants
PR Description
This is an attempt to fix #171
PRed from an upstream branch to test
AI Assistance Disclosure
AI tools were used for: