You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We implement Heliocentric Radial through the cylindrical representation of our Heliocentric coordinate frame. We're stuck with a 90-degree offset in the definition of the psi component, but at least we can have psi go from 0 deg to 360 deg (as requested by #5240).
ayshih
added
coordinates
Affects the coordinates submodule
No Backport
A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers)
labels
Apr 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coordinatesAffects the coordinates submoduleNo BackportA PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers)
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5240
We implement Heliocentric Radial through the cylindrical representation of our
Heliocentriccoordinate frame. We're stuck with a 90-degree offset in the definition of thepsicomponent, but at least we can havepsigo from 0 deg to 360 deg (as requested by #5240).