Skip to content

Wrap the psi component of Heliocentric Radial at 360 deg#5242

Merged
nabobalis merged 1 commit intosunpy:masterfrom
ayshih:hcr_psi_wrap
Apr 23, 2021
Merged

Wrap the psi component of Heliocentric Radial at 360 deg#5242
nabobalis merged 1 commit intosunpy:masterfrom
ayshih:hcr_psi_wrap

Conversation

@ayshih
Copy link
Copy Markdown
Member

@ayshih ayshih commented Apr 22, 2021

Closes #5240

We implement Heliocentric Radial through the cylindrical representation of our Heliocentric coordinate frame. We're stuck with a 90-degree offset in the definition of the psi component, but at least we can have psi go from 0 deg to 360 deg (as requested by #5240).

@pep8speaks
Copy link
Copy Markdown

pep8speaks commented Apr 22, 2021

Hello @ayshih! Thanks for updating this PR.

Line 579:101: E501 line too long (189 > 100 characters)
Line 571:101: E501 line too long (189 > 100 characters)
Line 563:101: E501 line too long (189 > 100 characters)
Line 456:101: E501 line too long (184 > 100 characters)
Line 451:101: E501 line too long (160 > 100 characters)
Line 446:101: E501 line too long (184 > 100 characters)
Line 381:101: E501 line too long (136 > 100 characters)
Line 375:101: E501 line too long (145 > 100 characters)
Line 369:101: E501 line too long (136 > 100 characters)
Line 350:101: E501 line too long (104 > 100 characters)
Line 320:101: E501 line too long (142 > 100 characters)
Line 313:101: E501 line too long (142 > 100 characters)
Line 305:101: E501 line too long (185 > 100 characters)
Line 254:101: E501 line too long (127 > 100 characters)
Line 244:101: E501 line too long (128 > 100 characters)
Line 241:101: E501 line too long (127 > 100 characters)
Line 66:101: E501 line too long (102 > 100 characters)
Line 53:101: E501 line too long (107 > 100 characters)

Comment last updated at 2021-04-22 14:23:35 UTC

@ayshih ayshih added coordinates Affects the coordinates submodule No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers) labels Apr 22, 2021
@ayshih ayshih marked this pull request as ready for review April 22, 2021 14:23
@ayshih ayshih requested a review from a team as a code owner April 22, 2021 14:23
@nabobalis nabobalis added this to the 3.0 milestone Apr 22, 2021
@nabobalis nabobalis merged commit 859391f into sunpy:master Apr 23, 2021
@ayshih ayshih deleted the hcr_psi_wrap branch April 30, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

coordinates Affects the coordinates submodule No Backport A PR that isn't to be backported to any release branch. (To be used as a flag to other maintainers)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Confusion with Heliocentric Cartesian vs Heliocentric Radial angles

5 participants