Skip to content

fix: align purge cache with storage-js and cover with contract tests - #52

Merged
diegofesanto merged 1 commit into
feature/purge-cachefrom
purge-cache-update
Jul 29, 2026
Merged

fix: align purge cache with storage-js and cover with contract tests#52
diegofesanto merged 1 commit into
feature/purge-cachefrom
purge-cache-update

Conversation

@Tr00d

@Tr00d Tr00d commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review follow-up from #50:

  • Drop FetchParameter/FetchCache: mismodeled storage-js FetchParameters (abort signal only) and were serialized into the DELETE body. Cancellation is already carried by CancellationToken; the purge now sends no body.
  • Default PurgeCacheOptions.Transformations to null so the default purges every cached version, matching storage-js (was true → transformations-only).
  • Emit transformations=true only when requested, and append ? only when a query exists (no trailing ?).
  • Add XML docs/examples to the new public members.
  • Replace the E2E purge tests with contract tests (WireMock + stub handler): path/method, empty body, success message, transformations serialization, default-purges-everything, and token forwarding.

To be merged in other pull request.

@Tr00d
Tr00d requested a review from diegofesanto July 29, 2026 13:10
@Tr00d Tr00d mentioned this pull request Jul 29, 2026
Merged
@diegofesanto
diegofesanto merged commit 2f4651c into feature/purge-cache Jul 29, 2026
Tr00d added a commit that referenced this pull request Jul 29, 2026
@diegofesanto @Tr00d
feat: implement purge cache issue (#50)
41ee1f8 
* feat(): implement purge cache issue

* fix: align purge cache with storage-js and cover with contract tests (#52)

---------

Co-authored-by: Guillaume Faas <59444272+Tr00d@users.noreply.github.com>
@Tr00d
Tr00d deleted the purge-cache-update branch July 30, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@diegofesanto diegofesanto diegofesanto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Tr00d @diegofesanto