Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Conversation

@bariqhibat
Copy link
Contributor

@bariqhibat bariqhibat commented Oct 6, 2021

This should resolve #7

Copied structure from https://github.com/supabase/gotrue-js

Signed-off-by: Bariq <bariqhibat@gmail.com>
Signed-off-by: Bariq <bariqhibat@gmail.com>
@J0
Copy link
Contributor

J0 commented Oct 7, 2021

Hey @bariqhibat,

Thanks for the PR, it looks great! Just one request: could you add a test case for this? There should be some from the js version that you can directly port over. Am aware that the CI is failing but we're hoping to get that fixed so that we can have a robust library. A test case would be really helpful in getting us towards that goal :)

JL

Signed-off-by: Bariq <bariqhibat@gmail.com>
Signed-off-by: Bariq <bariqhibat@gmail.com>
@bariqhibat
Copy link
Contributor Author

Hey @bariqhibat,

Thanks for the PR, it looks great! Just one request: could you add a test case for this? There should be some from the js version that you can directly port over. Am aware that the CI is failing but we're hoping to get that fixed so that we can have a robust library. A test case would be really helpful in getting us towards that goal :)

JL

Absolutely, just finished it! I refer to this page from this line until the end.

Signed-off-by: Bariq <bariqhibat@gmail.com>
@J0 J0 self-requested a review October 9, 2021 21:40
@J0
Copy link
Contributor

J0 commented Oct 9, 2021

Looks great, thanks for your contribution! Feel free to ping me if you'd like some Supabase stickers! My handle is J0 on the Supabase Discord :)

@J0 J0 merged commit f237f15 into supabase:main Oct 9, 2021
@bariqhibat
Copy link
Contributor Author

Looks great, thanks for your contribution! Feel free to ping me if you'd like some Supabase stickers! My handle is J0 on the Supabase Discord :)

Haha that'd be awesome! Sure thing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Gotrue library to Support Phone OTP

2 participants