Skip to content
This repository was archived by the owner on Sep 8, 2025. It is now read-only.

Conversation

@leynier
Copy link
Contributor

@leynier leynier commented Dec 3, 2021

Also, increase coverage, update dependencies, fix #40, fix #43, and resolve #41

dependabot bot and others added 8 commits December 3, 2021 14:05
Bumps [pre-commit](https://github.com/pre-commit/pre-commit) from 2.15.0 to 2.16.0.
- [Release notes](https://github.com/pre-commit/pre-commit/releases)
- [Changelog](https://github.com/pre-commit/pre-commit/blob/master/CHANGELOG.md)
- [Commits](pre-commit/pre-commit@v2.15.0...v2.16.0)

---
updated-dependencies:
- dependency-name: pre-commit
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
chore(deps-dev): bump pre-commit from 2.15.0 to 2.16.0
Bumps [faker](https://github.com/joke2k/faker) from 9.8.2 to 9.9.0.
- [Release notes](https://github.com/joke2k/faker/releases)
- [Changelog](https://github.com/joke2k/faker/blob/master/CHANGELOG.md)
- [Commits](joke2k/faker@v9.8.2...v9.9.0)

---
updated-dependencies:
- dependency-name: faker
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
chore(deps-dev): bump faker from 9.8.2 to 9.9.0
Bumps [sphinx](https://github.com/sphinx-doc/sphinx) from 4.3.0 to 4.3.1.
- [Release notes](https://github.com/sphinx-doc/sphinx/releases)
- [Changelog](https://github.com/sphinx-doc/sphinx/blob/4.x/CHANGES)
- [Commits](sphinx-doc/sphinx@v4.3.0...v4.3.1)

---
updated-dependencies:
- dependency-name: sphinx
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
chore(deps-dev): bump sphinx from 4.3.0 to 4.3.1
@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #37 (59635a9) into main (d012ae8) will increase coverage by 3.41%.
The diff coverage is 100.00%.

❗ Current head 59635a9 differs from pull request most recent head 0f05aa8. Consider uploading reports for the commit 0f05aa8 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
+ Coverage   79.88%   83.30%   +3.41%     
==========================================
  Files          14       14              
  Lines        1054     1054              
==========================================
+ Hits          842      878      +36     
+ Misses        212      176      -36     
Impacted Files Coverage Δ
gotrue/_async/client.py 89.07% <100.00%> (+7.56%) ⬆️
gotrue/_sync/client.py 89.07% <100.00%> (+7.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3878d91...0f05aa8. Read the comment docs.

leynier and others added 12 commits December 4, 2021 17:33
Bumps [black](https://github.com/psf/black) from 21.11b1 to 21.12b0.
- [Release notes](https://github.com/psf/black/releases)
- [Changelog](https://github.com/psf/black/blob/main/CHANGES.md)
- [Commits](https://github.com/psf/black/commits)

---
updated-dependencies:
- dependency-name: black
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [faker](https://github.com/joke2k/faker) from 9.9.0 to 10.0.0.
- [Release notes](https://github.com/joke2k/faker/releases)
- [Changelog](https://github.com/joke2k/faker/blob/master/CHANGELOG.md)
- [Commits](joke2k/faker@v9.9.0...v10.0.0)

---
updated-dependencies:
- dependency-name: faker
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
chore(deps-dev): bump black from 21.11b1 to 21.12b0
Also add argument for replace or not default headers
chore(deps-dev): bump faker from 9.9.0 to 10.0.0
@leynier
Copy link
Contributor Author

leynier commented Dec 11, 2021

The test is failing because of this supabase/auth#301

dependabot bot and others added 4 commits December 14, 2021 15:47
Bumps [commitizen](https://github.com/commitizen-tools/commitizen) from 2.20.0 to 2.20.2.
- [Release notes](https://github.com/commitizen-tools/commitizen/releases)
- [Changelog](https://github.com/commitizen-tools/commitizen/blob/master/CHANGELOG.md)
- [Commits](commitizen-tools/commitizen@v2.20.0...v2.20.2)

---
updated-dependencies:
- dependency-name: commitizen
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
chore(deps-dev): bump commitizen from 2.20.0 to 2.20.2
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Dec 17, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.19%.

Quality metrics Before After Change
Complexity 2.74 ⭐ 3.08 ⭐ 0.34 👎
Method Length 46.53 ⭐ 49.13 ⭐ 2.60 👎
Working memory 6.51 🙂 6.47 🙂 -0.04 👍
Quality 78.64% 77.45% -1.19% 👎
Other metrics Before After Change
Lines 2108 2287 179
Changed files Quality Before Quality After Quality Change
gotrue/exceptions.py 80.03% ⭐ 80.70% ⭐ 0.67% 👍
gotrue/_async/client.py 74.74% 🙂 74.31% 🙂 -0.43% 👎
gotrue/_sync/client.py 75.03% ⭐ 74.60% 🙂 -0.43% 👎
tests/_async/test_client_with_auto_confirm_enabled.py 83.12% ⭐ 79.91% ⭐ -3.21% 👎
tests/_async/test_client_with_sign_ups_disabled.py 75.84% ⭐ 75.84% ⭐ 0.00%
tests/_sync/test_client_with_auto_confirm_enabled.py 83.31% ⭐ 80.18% ⭐ -3.13% 👎
tests/_sync/test_client_with_sign_ups_disabled.py 75.99% ⭐ 75.99% ⭐ 0.00%

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
gotrue/_async/client.py AsyncGoTrueClient.get_session_from_url 15 🙂 219 ⛔ 14 😞 36.39% 😞 Try splitting into smaller methods. Extract out complex expressions
gotrue/_sync/client.py SyncGoTrueClient.get_session_from_url 15 🙂 217 ⛔ 14 😞 36.53% 😞 Try splitting into smaller methods. Extract out complex expressions
gotrue/_async/client.py AsyncGoTrueClient.sign_in 11 🙂 115 🙂 10 😞 56.40% 🙂 Extract out complex expressions
gotrue/_sync/client.py SyncGoTrueClient.sign_in 11 🙂 108 🙂 10 😞 57.31% 🙂 Extract out complex expressions
gotrue/_async/client.py AsyncGoTrueClient.__init__ 3 ⭐ 89 🙂 16 ⛔ 58.56% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@dreinon dreinon requested a review from J0 December 19, 2021 15:29
@dreinon
Copy link
Contributor

dreinon commented Dec 19, 2021

@anand2312 can you review this?

@dreinon dreinon merged commit 740d866 into supabase:main Dec 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

3 participants