Skip to content

Conversation

@issuedat
Copy link
Contributor

@issuedat issuedat commented Nov 17, 2025

The pg_trgm extension might already exist under a different schema, in which case, the create index statements will need to reference the schema when using the extension if the extension is not part of the search_path.

This PR:

  • removes the migration to create the pg_trgm extension
  • looks for which schema the extension might live in
  • adds a check in the indexworker to ensure the extension exists before proceeding
    • this is mostly a nice-to-have as any failed indexes would be transparently re-created next time the worker runs

@issuedat issuedat requested a review from a team as a code owner November 17, 2025 14:29
@coveralls
Copy link

coveralls commented Nov 17, 2025

Pull Request Test Coverage Report for Build 19457583036

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 22 of 22 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.03%) to 68.381%

Totals Coverage Status
Change from base Build 19454135247: 0.03%
Covered Lines: 14369
Relevant Lines: 21013

💛 - Coveralls

@issuedat issuedat force-pushed the iat/remove-create-extension-pg-trgm branch from 1a1aa93 to c274656 Compare November 17, 2025 20:17
@issuedat issuedat changed the title chore: remove migration to create pg_trgm extension fix(indexworker): detect which schema pg_trgm exists in Nov 17, 2025
@issuedat issuedat enabled auto-merge (squash) November 18, 2025 07:19
@issuedat issuedat merged commit 4be12b3 into master Nov 18, 2025
4 of 5 checks passed
@issuedat issuedat deleted the iat/remove-create-extension-pg-trgm branch November 18, 2025 07:19
cemalkilic pushed a commit that referenced this pull request Nov 24, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.183.0](v2.182.1...v2.183.0)
(2025-11-20)


### Features

* async, concurrent index creation for users table
([#2239](#2239))
([a1146bf](a1146bf))
* **indexworker:** use `auth_trgm` extension if available
([#2263](#2263))
([05daa43](05daa43))
* **oauthserver:** add OpenID Connect support
([#2250](#2250))
([162788f](162788f))
* **oauthserver:** update oauth grant list & authorization details
response structure
([#2247](#2247))
([137ea92](137ea92))
* **oauthserver:** use `NewOAuthServerAuthorizationParams` &
configurable ttl for authorization
([#2254](#2254))
([61632f8](61632f8))


### Bug Fixes

* **indexworker:** detect which schema `pg_trgm` exists in
([#2260](#2260))
([4be12b3](4be12b3))
* look for refresh token on mfa verification only in v1
([#2249](#2249))
([2906b24](2906b24))
* mfa verify now works with refresh token algorithm v2
([#2246](#2246))
([4e8275f](4e8275f))
* **social-auth:** default to current_user:read for Figma provider
([#2195](#2195))
([f409d11](f409d11))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants