-
Notifications
You must be signed in to change notification settings - Fork 561
feat(oauthserver): update oauth grant list & authorization details response structure #2247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 19165582260Details
💛 - Coveralls |
internal/api/oauthserver/handlers.go
Outdated
| ClientID: client.ID.String(), | ||
| ClientName: utilities.StringValue(client.ClientName), | ||
| ClientURI: utilities.StringValue(client.ClientURI), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we're nesting these fields under the client object, I think it might make more sense to avoid repeating the client_ suffix for the field names — WDYT?
{
"client": {
"id": "...",
"name": "...",
"uri": "...",
}
}If the client_id is the id column in the table, I think it shouldn't result in any confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤦 vibe coded this "small" change, sorry. fixed it now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
p.s I updated this, but it also impacts the existing endpoint (GET /oauth/authorizations/{authorization_id}) response, I'll add this to release notes as it'll break the existing beta users'.
update oauth grant list response structure for api consistency