Chore/tidy operator token#124
Merged
Merged
Conversation
awalias
commented
Jun 29, 2021
| p := jwt.Parser{ValidMethods: []string{jwt.SigningMethodHS256.Name}} | ||
| _, err := p.ParseWithClaims(signature, &claims, func(token *jwt.Token) (interface{}, error) { | ||
| return []byte(a.config.OperatorToken), nil | ||
| return []byte(config.JWT.Secret), nil |
Member
Author
There was a problem hiding this comment.
actually not needed since we're not utilizing multi-instance mode anyway
Member
There was a problem hiding this comment.
yeah but i think we may need it in the future when we move gotrue to multi-tenant 😅
Member
Author
|
tested locally with facebook, twitter, google, and invite |
kangmingtay
reviewed
Jun 29, 2021
kangmingtay
approved these changes
Jul 1, 2021
Contributor
|
🎉 This PR is included in version 1.10.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
Chore/tidy operator token
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
purpose is to remove operator token from non-multi-instance deployments