Feat: Generate email action links#133
Merged
Merged
Conversation
awalias
approved these changes
Jul 13, 2021
Member
awalias
left a comment
awalias
left a comment
There was a problem hiding this comment.
tested everything and it works great!
kangmingtay
commented
Jul 13, 2021
Comment on lines
+41
to
+55
| if user != nil { | ||
| if user.IsConfirmed() { | ||
| return unprocessableEntityError(DuplicateEmailMsg) | ||
| } | ||
| } else { | ||
| signupParams := SignupParams{ | ||
| Email: params.Email, | ||
| Data: params.Data, | ||
| Aud: aud, | ||
| Provider: "email", | ||
| } | ||
| user, err = a.signupNewUser(ctx, tx, &signupParams) | ||
| if err != nil { | ||
| return err | ||
| } |
Member
Author
There was a problem hiding this comment.
Bundled fix for #134 as well for convenience. If a user has been signed up but not confirmed yet, an admin should still be able to send out invite links to the same user.
Contributor
|
🎉 This PR is included in version 1.11.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closed
uxodb
pushed a commit
to uxodb/auth
that referenced
this pull request
Nov 13, 2024
Feat: Generate email action links
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Allows an admin user to generate email action links (
signup,magiclink,recovery,invite).What is the current behavior?
Admin user cannot make use of their own custom email service (e.g. Sendgrid) or email templates to serve their customers.
#109
What is the new behavior?
Adds a new admin endpoint:
POST /admin/generate_link?type=TYPE&redirect_to=REDIRECT_URLAllows an admin user to generate the corresponding email action link to send in their custom email templates.
Additional context
Requires admin credentials because the email action links contain the verification token used to sign a user in.
Sign up a new user via magiclink
Request:
Response: