feat(security): prevent user enumeration via timing attacks#2223
Closed
maxdinech wants to merge 1 commit intosupabase:masterfrom
Closed
feat(security): prevent user enumeration via timing attacks#2223maxdinech wants to merge 1 commit intosupabase:masterfrom
maxdinech wants to merge 1 commit intosupabase:masterfrom
Conversation
Adds timing obfuscation to password authentication to prevent user enumeration. Configurable via GOTRUE_SECURITY_TIMING_OBFUSCATION_DELAY (default: 0, disabled). Recommended value: 40ms for typical workloads.
Author
|
Note : on more powerful instances, a value of just 10ms for |
Contributor
|
Thank you for this PR. We do not plan on adding timing obfuscation on this endpoint at this time. It's a guessing game, and making requests slower has other resource implications. We do believe that en-masse user enumeration can be prevented by adequately configuring rate limiting and captcha. |
Contributor
|
Also @maxdinech please review Supabase's security.txt file before submitting more fixes that might indicate potential security issues. Please follow a responsible security vulnerability (even if suspected) process. |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature - Security enhancement
What is the current behavior?
Password authentication endpoints leak information about user existence through timing differences:
This timing difference allows attackers to enumerate valid email addresses/phone numbers by measuring response times, even without rate limiting bypass.
We discovered this vulnerability during a penetration test of our self-hosted Supabase instance. Testing showed a consistent 100ms+ difference that reliably identified valid accounts.
What is the new behavior?
Adds a new configuration option
GOTRUE_SECURITY_TIMING_OBFUSCATION_DELAYthat adds timing obfuscation to invalid login attempts.Changes:
GOTRUE_SECURITY_TIMING_OBFUSCATION_DELAYconfiguration optionImplementation details:
.Eager()loading of Factors/Identities (~30-50ms)Testing performed
Timing analysis on staging environment (20 samples each):
Valid user and invalid user response times now overlap significantly, preventing reliable enumeration.