Skip to content

Conversation

@hf
Copy link
Contributor

@hf hf commented Dec 8, 2025

Increments the refresh token counter by 2 instead of 1 on the MFA verify action. This ensures that the previous refresh tokens (who were issued when the session was at AAL1) cannot be used any more to issue an AAL2 session by reuse.

@hf hf requested a review from a team as a code owner December 8, 2025 10:23
@coveralls
Copy link

Pull Request Test Coverage Report for Build 20024725903

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 68.435%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/api/token.go 0 1 0.0%
Totals Coverage Status
Change from base Build 19871602451: 0.0%
Covered Lines: 14641
Relevant Lines: 21394

💛 - Coveralls

@hf hf merged commit 2a38668 into master Dec 8, 2025
9 checks passed
@hf hf deleted the hf/mfa-rt-2-counter-2 branch December 8, 2025 11:14
issuedat added a commit that referenced this pull request Dec 9, 2025
🤖 I have created a release *beep* *boop*
---


##
[2.184.0](v2.183.0...v2.184.0)
(2025-12-08)


### Features

* increment refresh token counter by 2 for mfa verify
([#2284](#2284))
([2a38668](2a38668))
* load template cache at startup for fault tolerance
([#2261](#2261))
([511c3a4](511c3a4))
* **oauth:** add support for X/Twitter v2 provider
([#2275](#2275))
([7f36eb0](7f36eb0))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: issuedat <165281975+issuedat@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants