Skip to content

chore: move the version code from version.go into separate pkg#2383

Merged
cstockton merged 1 commit intomasterfrom
cs/fix-build-system
Feb 18, 2026
Merged

chore: move the version code from version.go into separate pkg#2383
cstockton merged 1 commit intomasterfrom
cs/fix-build-system

Conversation

@cstockton
Copy link
Contributor

I missed that the build-strip Makefile step wrote a new version.go file. Moving this code around is easier then messing with build system right now.

I missed that the build-strip Makefile step wrote a new version.go
file. Moving this code around is easier then messing with build
system right now.
@cstockton cstockton requested a review from a team as a code owner February 18, 2026 22:01
@coderabbitai
Copy link

coderabbitai bot commented Feb 18, 2026

No actionable comments were generated in the recent review. 🎉


📝 Walkthrough

Summary by CodeRabbit

  • Refactor
    • Reorganized internal version metrics initialization code to improve maintainability and code structure.

Walkthrough

The changes reorganize version metric initialization logic by moving it from the internal/utilities/version.go file into a new internal/utilities/version/ subpackage. The InitVersionMetrics function is extracted from internal/utilities/version.go (126 lines removed) and reimplemented in the new internal/utilities/version/version.go file (123 lines added). The function signature changes to accept the version string as an explicit parameter: InitVersionMetrics(ctx context.Context, ver string) instead of InitVersionMetrics(ctx context.Context). The call site in internal/observability/metrics.go is updated to pass utilities.Version as the second argument. Tests are updated to reflect the new package structure and function signature.


Comment @coderabbitai help to get the list of available commands and usage tips.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 22159392882

Details

  • 75 of 76 (98.68%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 69.141%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/observability/metrics.go 0 1 0.0%
Totals Coverage Status
Change from base Build 22140967144: -0.004%
Covered Lines: 15023
Relevant Lines: 21728

💛 - Coveralls

@cstockton cstockton merged commit 5857658 into master Feb 18, 2026
7 checks passed
@cstockton cstockton deleted the cs/fix-build-system branch February 18, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments