Draft
Conversation
RFC 7235 §2.1 requires HTTP auth scheme names to be case-insensitive. The current regex only accepts "Bearer" and "bearer", rejecting spec-compliant variants like "BEARER".
Change bearerRegexp to use (?i) flag so all capitalizations of "bearer" are accepted, as required by the HTTP authentication framework spec.
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: case-insensitive Bearer token scheme matching
bearerRegexponly acceptedBearerandbearerRFC 7235 §2.1 requires auth scheme names to be case-insensitive.
Changed the regex to use the
(?i)flag so all capitalizations (e.g.BEARER) are accepted.Test plan
TestExtractBearerTokenCaseInsensitivecoveringBearer,bearer,BEARER,bEaReR,BeArEr