Skip to content

fix: source WebAuthn RP config from env vars#2490

Open
fadymak wants to merge 1 commit intomasterfrom
fm/prodsec-69-mfa-webauthn-config
Open

fix: source WebAuthn RP config from env vars#2490
fadymak wants to merge 1 commit intomasterfrom
fm/prodsec-69-mfa-webauthn-config

Conversation

@fadymak
Copy link
Copy Markdown
Contributor

@fadymak fadymak commented Apr 20, 2026

Requires relying party configuration to be set in environment variables.

  • MFA WebAuthn challenge and verify no longer accept rpId / rpOrigins from the request body.
  • Validates GOTRUE_WEBAUTHN_RP_* at startup whenever MFA WebAuthn enroll or verify environment vars are enabled.

rpId and rpOrigins under the webauthn object on POST /factors/{factor_id}/challenge and POST /factors/{factor_id}/verify are now silently ignored — they must no longer be sent in the request bodies.

GOTRUE_WEBAUTHN_RP_ID, GOTRUE_WEBAUTHN_RP_ORIGINS, and GOTRUE_WEBAUTHN_RP_DISPLAY_NAME must be set if MFA WebAuthn enroll or verify are enabled.

@fadymak fadymak requested a review from a team as a code owner April 20, 2026 11:27
@fadymak fadymak changed the title fix(mfa): source WebAuthn RP config from env vars fix: source WebAuthn RP config from env vars Apr 20, 2026
Copy link
Copy Markdown
Contributor

@cstockton cstockton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants