feat: create tools directory for deterministic builds#2522
Merged
Conversation
Currently a test run can pass at any phase, locally, in the pr, or worst after the PR is merged and the release pr is building. This change adds a tool dir where we pin our tools and update them explicitly like we do with go.mod in the main repo today. This will let whoever does the PR that updates the tools version also make sure new lints are resolved with it.
Contributor
Author
|
So this is the workflow as expected, upgraded the tools, now we see the tests failing and can fix them. But all future pr's once merged will remain stable. |
![depthfirst-app[bot]](https://avatars.githubusercontent.com/in/1021002?s=60&v=4){kind=small}
cstockton
force-pushed
the
cs/feat-tools-dir
branch
from
53d34ce to
3d34e66
Compare
cemalkilic
approved these changes
May 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently a test run can pass at any phase, locally, in the pr, or worst after the PR is merged and the release pr is building. This change adds a tool dir where we pin our tools and update them explicitly like we do with go.mod in the main repo today.
This will let whoever does the PR that updates the tools version also make sure new lints are resolved with it.