feat: fix the vulncheck-filter to parse the text format instead#2525
Open
cstockton wants to merge 4 commits into
Open
feat: fix the vulncheck-filter to parse the text format instead#2525cstockton wants to merge 4 commits into
cstockton wants to merge 4 commits into
Conversation
![depthfirst-app[bot]](https://avatars.githubusercontent.com/in/1021002?s=60&v=4){kind=small}
cemalkilic
approved these changes
May 12, 2026
The existing parser wasn't decoding any values. Once I fixed the decoding it started printing 64 results. After looking into it I realized that govulncheck cmd does some additional aggregation. It turns out that it's non-trivial, rather than try to duplicate that I just parsed the text output instead.
cstockton
force-pushed
the
cs/feat-tools-dir-vulncheck-fix
branch
from
f2ed07a to
2a0603a
Compare
Resolved all findings from govulncheck, all of which were fixed with a go version upgrade. I changed vulncheck filter to parse the output of the command line instead of the JSON. This is because the CLI does a great deal of post processing after the fact that I did not want to emulate in the parser. It was much simpler to parse the text output. If it changes in the future the parser is simple to change. The parser is also much more strict, it expects vuln list or a success msg which should prevent silently passing with vulns found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing parser wasn't decoding any values. Once I fixed the decoding it started printing 64 results. After looking into it I realized that
govulncheckcmd does some additional aggregation. It turns out that it's non-trivial, rather than try to duplicate thatI just parsed the text output instead.
This change should cause the tests to start failing.