Prevent passkey authentication for soft-deleted users#2557
Closed
depthfirst-app[bot] wants to merge 2 commits into
Closed
Conversation
…c0e907ca7_51bc5a6e525fb336543098af32316e68
Contributor
|
Closing in favour of the approach here: #2564 |
fadymak
deleted the
depthfirst_ca0b1547f77f5261458a6e91ca2ccb2c0e907ca7_51bc5a6e525fb336543098af32316e68
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a broken authorization flaw in discoverable WebAuthn/passkey authentication.
Vulnerability
PasskeyAuthenticationVerifyloaded the user from the WebAuthnuserHandleand checked confirmation/banned state, but did not reject users withdeleted_atset.Impact
A softly deleted account that still had a registered passkey could successfully complete passkey verification and receive fresh refresh/access tokens.
Solution
deleted_atguard ininternal/api/passkey_authentication.gobefore any token issuance logic.user_not_foundfor soft-deleted users to avoid authenticating revoked accounts.internal/api/passkey_authentication_test.goto verify soft-deleted users are forbidden from passkey login.🔍 View Vulnerability Details: Code Vulnerability