fix(vulncheck): ignore GO-2026-5004 (pgx/v4, not reachable)#2602
Merged
Conversation
cstockton
approved these changes
Jun 29, 2026
cstockton
pushed a commit
that referenced
this pull request
Jun 29, 2026
🤖 I have created a release *beep* *boop* --- ## [2.192.0](v2.191.0...v2.192.0) (2026-06-29) ### Features * **custom-oauth:** add per-provider custom_claims_allowlist ([#2576](#2576)) ([acecb06](acecb06)) ### Bug Fixes * **tests:** rely on error codes for hooks tests to work across PG backends ([ee91c5f](ee91c5f)) * **vulncheck:** ignore GO-2026-5004 (pgx/v4, not reachable) ([#2602](#2602)) ([f1cc16f](f1cc16f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: supabase-releaser[bot] <223506987+supabase-releaser[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
GO-2026-5004to thevulncheck-filterignore map somake vulncheckpasses again.Why it's safe to ignore
GO-2026-5004is a SQL injection in pgx'ssanitize.SanitizeSQL, reaching us transitively:pop/v6 → pgx/v4/stdlib → pgx/v4.It only triggers when all of these hold:
separate bind parameters, so nothing is string-interpolated client-side),
We're not impacted:
We never use the simple protocol. No
PreferSimpleProtocol/SimpleProtocol/QueryExecModeanywhere in the tree: all DB access goes throughdatabase/sql→ pgx/v4stdlib→ pop/v6 on the default extended protocol, soSanitizeSQLis never exercised.The advisory itself calls it "unlikely to occur outside of a contrived scenario."
Why not fix instead
There is no upstream fix for pgx/v4 (only v5 ≥ 5.9.2 is patched), and pgx/v4 is transitive via
pop/v6, so itcan't be bumped on its own. Same situation as the existing
GO-2026-4518entry. If we ever opt into the simpleprotocol, this should be revisited.