feat(cli): migrate network bans#5382
Merged
Merged
Conversation
- Correct get/SIDE_EFFECTS.md API method (POST .../retrieve, not GET) - Document requester_ip in remove/SIDE_EFFECTS.md request body - Add Files Written + Telemetry sections to both SIDE_EFFECTS.md files - Hoist encodeBannedIpsToml to network-bans.encoders.ts with unit tests - Add output.task spinner to get handler text mode (sibling parity) - Reorder get handler branches and document --output pretty/json fallthrough - Clarify remove handler precedence rule with explanatory comment - Fill test coverage: yaml/json/pretty for get, network failures for both, --output-format stream-json for remove, telemetry/cache assertions on success and failure for both commands
Coly010
approved these changes
May 29, 2026
Contributor
Coly010
left a comment
Coly010
left a comment
There was a problem hiding this comment.
Thank you! This was great work!
There were some minor things that appeared in my feedback, so I addressed them in the commit I added. Thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Ports
supabase network-bans getandsupabase network-bans removefrom the Go proxy to native TypeScriptWhat's Introduced
Replaces the
LegacyGoProxypath for bothnetwork-bansleaf commands with native handlerswired through the existing legacy management-api runtime and instrumentation path
Coverage
Added a small integration suite covering this as well