fix(cli): schema-decode telemetry config#5412
Merged
Merged
Conversation
Coly010
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Telemetry config loading now uses an Effect Schema boundary instead of a raw
JSON.parsecast. Invalid, unreadable, or malformedtelemetry.jsonis treated as absent local telemetry state, so telemetry state cannot crash unrelated CLI commands.The telemetry config type is now derived from the runtime schema, and internal absence is represented with
Optionrather thannull.telemetry statusstill serializes missing persisted consent asnullat the output boundary.Context
PR #5405 fixed the immediate empty JSON crash by catching parse errors, but structurally invalid JSON could still be accepted as
TelemetryConfig. This follows the existing repo pattern ofSchema.fromJsonString(...)for local state files and keeps malformed telemetry state best-effort and silent.