fix(cli): read Go Windows credentials via findCredentials#5423
Merged
jgoux merged 8 commits intoJun 2, 2026
Conversation
jgoux
approved these changes
Jun 2, 2026
Contributor
jgoux
left a comment
There was a problem hiding this comment.
Thanks for your contribution! I added small changes, can you confirm it works before merging?
Contributor
Author
|
Tested the updated branch on local Windows and on a clean I used Results:
I also reran the focused unit test locally: npx bun run .\node_modules\vitest\vitest.mjs run src/legacy/auth/legacy-credentials.layer.unit.test.ts --config vitest.config.tsResult: 17 tests passed. |
Contributor
|
Thanks for pushing this to the finish line! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5415.
The Windows fallback added for Go-written credentials used
Entry.withTarget(...).getPassword().On Windows, that does not read the Go-shaped target credential correctly.
findCredentials(service, target)can read it, so this uses that path for the Go Windows target while preserving the existing default keyring and file fallback behavior.The legacy credentials unit test now covers the target lookup path.
Tested with: