Skip to content

fix: skip migrations when backup volume exists #1057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 4, 2023
Merged

fix: skip migrations when backup volume exists #1057

merged 4 commits into from
May 4, 2023

Conversation

sweatybridge
Copy link
Contributor

What kind of change does this PR introduce?

Bug fix #1055

What is the new behavior?

  • introduced a scoped variable for checking if backup exists
  • refactors common error fs for testing

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner May 3, 2023 19:07
@gcrespi gcrespi mentioned this pull request May 3, 2023
Closed
2 tasks
@coveralls
Copy link

coveralls commented May 4, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4879733712

  • 14 of 15 (93.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 60.825%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/testing/fstest/open.go 9 10 90.0%
Totals Coverage Status
Change from base Build 4876674330: 0.2%
Covered Lines: 4349
Relevant Lines: 7150
💛 - Coveralls

@sweatybridge sweatybridge merged commit 9a6a98e into main May 4, 2023
@sweatybridge sweatybridge deleted the fix-setup branch May 4, 2023 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soedirgo soedirgo soedirgo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

supabase start failed after supabase stop --backup + data lost

3 participants

@sweatybridge @coveralls @soedirgo