Skip to content

Conversation

@soedirgo
Copy link
Member

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

If a column has multiple check constraints, pg-meta returns duplicate entries on GET /columns and generated types.

What is the new behavior?

Fix the bug

Additional context

Fixes supabase/postgres-meta#590

@soedirgo soedirgo requested a review from a team as a code owner August 17, 2023 07:45
@coveralls
Copy link

coveralls commented Aug 17, 2023

Pull Request Test Coverage Report for Build 5898012083

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 56.87%

Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.31%
Totals Coverage Status
Change from base Build 5898005518: -0.04%
Covered Lines: 4851
Relevant Lines: 8530

💛 - Coveralls

@sweatybridge sweatybridge enabled auto-merge (squash) August 18, 2023 02:08
@sweatybridge sweatybridge merged commit 04c65f3 into main Aug 18, 2023
@sweatybridge sweatybridge deleted the fix/pg-meta-duplicate-columns branch August 18, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

supabase gen types generates duplicate identifiers

4 participants