Skip to content

Conversation

@sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Sep 20, 2023

What kind of change does this PR introduce?

Bug fix #1508

What is the current behavior?

Turns out bitnami updated their docker hub image tag 1.20.1 which broke the generated userlist.txt bitnami/containers#48264 (comment)

We mirrored the image to our ECR repo and propagated the bug to cli stack.

What is the new behavior?

To prevent such breaking changes, we pin bitnami/pgbouncer to an immutable tag.
Also synced pgbouncer config to support logging in as non-postgres user.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner September 20, 2023 18:16
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6252516071

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 56.616%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/start/start.go 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.31%
Totals Coverage Status
Change from base Build 6251647271: -0.05%
Covered Lines: 4989
Relevant Lines: 8812

💛 - Coveralls

@sweatybridge sweatybridge merged commit 9a5eb48 into main Sep 21, 2023
@sweatybridge sweatybridge deleted the fix-pooler branch September 21, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Local pg-bouncer container startup auth error

3 participants