Skip to content

feat: allow configuring max header length for realtime #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2023
Merged

feat: allow configuring max header length for realtime #1785

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions internal/start/start.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -592,6 +592,7 @@ EOF
"DNS_NODES=''",
"RLIMIT_NOFILE=",
"REALTIME_IP_VERSION=" + string(utils.Config.Realtime.IpVersion),
fmt.Sprintf("MAX_HEADER_LENGTH=%d", utils.Config.Realtime.MaxHeaderLength),
},
Cmd: []string{
"/bin/sh", "-c",
Expand Down
8 changes: 5 additions & 3 deletions internal/utils/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,8 @@ var Config = config{
RootKey: "d4dc5b6d4a1d6a10b2c1e76112c994d65db7cec380572cc1839624d4be3fa275",
},
Realtime: realtime{
IpVersion: AddressIPv6,
IpVersion: AddressIPv6,
MaxHeaderLength: 4096,
},
Storage: storage{
Image: StorageImage,
Expand Down Expand Up @@ -275,8 +276,9 @@ type (
}

realtime struct {
Enabled bool `toml:"enabled"`
IpVersion AddressFamily `toml:"ip_version"`
Enabled bool `toml:"enabled"`
IpVersion AddressFamily `toml:"ip_version"`
MaxHeaderLength uint `toml:"max_header_length"`
}

studio struct {
Expand Down
2 changes: 1 addition & 1 deletion internal/utils/misc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ const (
VectorImage = "timberio/vector:0.28.1-alpine"
PgbouncerImage = "bitnami/pgbouncer:1.20.1-debian-11-r39"
GotrueImage = "supabase/gotrue:v2.125.1"
RealtimeImage = "supabase/realtime:v2.25.35"
RealtimeImage = "supabase/realtime:v2.25.50"
StorageImage = "supabase/storage-api:v0.43.11"
LogflareImage = "supabase/logflare:1.4.0"
// Should be kept in-sync with EdgeRuntimeImage
Expand Down
2 changes: 2 additions & 0 deletions internal/utils/templates/init_config.test.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ max_client_conn = 100
enabled = true
# Bind realtime via either IPv4 or IPv6. (default: IPv6)
ip_version = "IPv4"
# The maximum length in bytes of HTTP request headers. (default: 4096)
max_header_length = 8192

[studio]
enabled = true
Expand Down
2 changes: 2 additions & 0 deletions internal/utils/templates/init_config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,8 @@ max_client_conn = 100
enabled = true
# Bind realtime via either IPv4 or IPv6. (default: IPv6)
# ip_version = "IPv6"
# The maximum length in bytes of HTTP request headers. (default: 4096)
# max_header_length = 4096

[studio]
enabled = true
Expand Down