Skip to content

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Jan 28, 2024

What kind of change does this PR introduce?

Bug fix #1428 (comment)

What is the current behavior?

'*' was double escaped to '\''*'\'' by bash.

What is the new behavior?

Always set --schema flag so we don't need to optionally pass in --extension flag to pg_dump.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner January 28, 2024 06:59
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7684090367

  • -4 of 6 (33.33%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 58.764%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/db/dump/dump.go 2 6 33.33%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 11.76%
Totals Coverage Status
Change from base Build 7666136703: -0.04%
Covered Lines: 6135
Relevant Lines: 10440

💛 - Coveralls

@sweatybridge sweatybridge merged commit ba6773f into main Jan 28, 2024
@sweatybridge sweatybridge deleted the fix-pull branch January 28, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ERROR: multiple primary keys for table

2 participants